Bug 108101

Summary:

PLATFORM(IOS) should come before __MAC_OS_X_VERSION_MIN_REQUIRED

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

Platform

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	benjamin: review+

Description Pratik Solanki 2013-01-28 12:32:39 PST

__MAC_OS_X_VERSION_MIN_REQUIRED is not defined on iOS so code like the following fails to achieve its intended purpose

#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080 && !PLATFORM(IOS)

It should be updated to

#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080

Comment 1 Pratik Solanki 2013-01-28 12:36:08 PST

Created attachment 185036 [details]
Patch

Comment 2 David Kilzer (:ddkilzer) 2013-01-28 12:38:18 PST

I fixed this as a BUILD FIX in r140988.  <http://trac.webkit.org/changeset/140988>

Comment 3 Pratik Solanki 2013-01-28 12:40:11 PST

Yup. This is fixed.

Comment 4 Pratik Solanki 2013-01-28 12:42:30 PST

Umm. r140988 doesn't cover all the cases. There's a few more places that need to be fixed.

Comment 5 Pratik Solanki 2013-01-28 16:20:10 PST

Committed r141025: <http://trac.webkit.org/changeset/141025>