Bug 108095

Summary: Remove USE(OS_RANDOMNESS)
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andrew, benjamin, commit-queue, eric, paroga, rwlbuis, tonikitoo, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 108125    
Bug Blocks:    
Attachments:
Description Flags
proposed change none

Laszlo Gombos
Reported 2013-01-28 11:13:14 PST
USE_OS_RANDOMNESS seems to be always set, so we should consider removing the guard.
Attachments
proposed change (10.81 KB, patch)
2013-05-10 10:41 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2013-01-28 11:19:04 PST
Before proceeding with this work, I would like to get a confirmation that OS(QNX) is always set when PLATFORM(BLACKBERRY) set. Can someone help me to get a confirmation on this ? If PLATFORM(BLACKBERRY) assumes OS(QNX), that would mean that OS(UNIX) is defined, which would mean that USE(OS_RANDOMNESS) is set.
Yong Li
Comment 2 2013-01-28 11:29:33 PST
(In reply to comment #1) > Before proceeding with this work, I would like to get a confirmation that OS(QNX) is always set when PLATFORM(BLACKBERRY) set. > > Can someone help me to get a confirmation on this ? > > If PLATFORM(BLACKBERRY) assumes OS(QNX), that would mean that OS(UNIX) is defined Confirmed.
Laszlo Gombos
Comment 3 2013-05-10 10:41:32 PDT
Created attachment 201361 [details] proposed change Notice that WTF_USE_OS_RANDOMNESS was set to 1 for both OS(UNIX) and OS(WINDOWS). As far as I know OS(UNIX) and OS(WINDOWS) covers all the supported platforms on trunk.
WebKit Commit Bot
Comment 4 2013-05-10 18:26:21 PDT
Comment on attachment 201361 [details] proposed change Clearing flags on attachment: 201361 Committed r149921: <http://trac.webkit.org/changeset/149921>
WebKit Commit Bot
Comment 5 2013-05-10 18:26:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.