Bug 108087

Summary:

Web Inspector: in inspector-protocol tests do not swallow errors

Product:

WebKit

Reporter:

Peter Rybin <prybin>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Peter Rybin

Reported 2013-01-28 09:05:55 PST

If function the test function hasn't been found or failed to be compiled, test will timeout. Kill test in this case and provide error message.

Attachments
Patch (2.54 KB, patch) 2013-01-28 09:09 PST, Peter Rybin	no flags	Details Formatted Diff Diff
Patch (2.57 KB, patch) 2013-01-29 03:39 PST, Peter Rybin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Peter Rybin

Comment 1 2013-01-28 09:09:48 PST

Yury Semikhatsky

Comment 2 2013-01-29 03:34:20 PST

Comment on attachment 184993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184993&action=review > LayoutTests/http/tests/inspector-protocol/resources/protocol-test.js:89 > + if (typeof testFunction == "function") { == -> ===

Peter Rybin

Comment 3 2013-01-29 03:39:42 PST

Peter Rybin

Comment 4 2013-01-29 03:40:52 PST

(In reply to comment #2) > (From update of attachment 184993 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184993&action=review > > > LayoutTests/http/tests/inspector-protocol/resources/protocol-test.js:89 > > + if (typeof testFunction == "function") { > > == -> === Done

WebKit Review Bot

Comment 5 2013-01-29 04:58:35 PST

WebKit Review Bot

Comment 6 2013-01-29 04:58:39 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.