Bug 108075

Summary: Web Inspector: Inherit SidebarPane from View
Product: WebKit Reporter: Vladislav Kaznacheev <kaznacheev>
Component: Web Inspector (Deprecated)Assignee: Vladislav Kaznacheev <kaznacheev>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Vladislav Kaznacheev
Reported 2013-01-28 05:48:16 PST
WebInspector.SidebarPane class currently inherits from WebInspector.Object and requires special handling in the client code that otherwise mostly deals with WevInspector.View instances. Inheriting WebInspector.SidebarPane from WebInspector.View will streamline the code and simplify further enhancements to sidebar panes.
Attachments
Patch (6.88 KB, patch)
2013-01-28 06:10 PST, Vladislav Kaznacheev 		no flags
DetailsFormatted DiffDiff
Patch (8.58 KB, patch)
2013-01-28 07:09 PST, Vladislav Kaznacheev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vladislav Kaznacheev
Comment 1 2013-01-28 06:10:28 PST
Created attachment 184975 [details] Patch
Vladislav Kaznacheev
Comment 2 2013-01-28 07:09:35 PST
Created attachment 184979 [details] Patch
WebKit Review Bot
Comment 3 2013-01-28 08:15:57 PST
Comment on attachment 184979 [details] Patch Clearing flags on attachment: 184979 Committed r140968: <http://trac.webkit.org/changeset/140968>
WebKit Review Bot
Comment 4 2013-01-28 08:16:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.