Bug 108072

Summary: Web Inspector: [CPU Profile] Taking profile crashes renderer.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, caseq, eustas, haraken, japhet, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Eugene Klyuchnikov
Reported 2013-01-28 03:40:54 PST
This regression is caused by https://bugs.webkit.org/show_bug.cgi?id=107674 More precisely: in file ScriptProfiler.cpp it is explicitly declared that "start" and "stop" could be invoked with state == 0 (see "startForPage", "stopForPage", etc.) Accessing "isolate" of a null pointer causes crashes.
Attachments
Patch (4.52 KB, patch)
2013-01-28 04:03 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-01-28 04:03:41 PST
Created attachment 184967 [details] Patch
Yury Semikhatsky
Comment 2 2013-01-28 04:31:49 PST
Comment on attachment 184967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184967&action=review > Source/WebCore/bindings/v8/ScriptProfiler.cpp:80 > const v8::CpuProfile* profile = state ? In which cases it the state is 0?
WebKit Review Bot
Comment 3 2013-01-29 03:57:15 PST
Comment on attachment 184967 [details] Patch Clearing flags on attachment: 184967 Committed r141094: <http://trac.webkit.org/changeset/141094>
WebKit Review Bot
Comment 4 2013-01-29 03:57:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.