Bug 108072

Summary: Web Inspector: [CPU Profile] Taking profile crashes renderer.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, caseq, eustas, haraken, japhet, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Eugene Klyuchnikov 2013-01-28 03:40:54 PST
This regression is caused by https://bugs.webkit.org/show_bug.cgi?id=107674

More precisely: in file ScriptProfiler.cpp it is explicitly declared that "start" and "stop" could be invoked with state == 0 (see "startForPage", "stopForPage", etc.)
Accessing "isolate" of a null pointer causes crashes.
Comment 1 Eugene Klyuchnikov 2013-01-28 04:03:41 PST
Created attachment 184967 [details]
Patch
Comment 2 Yury Semikhatsky 2013-01-28 04:31:49 PST
Comment on attachment 184967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184967&action=review

> Source/WebCore/bindings/v8/ScriptProfiler.cpp:80
>      const v8::CpuProfile* profile = state ?

In which cases it the state is 0?
Comment 3 WebKit Review Bot 2013-01-29 03:57:15 PST
Comment on attachment 184967 [details]
Patch

Clearing flags on attachment: 184967

Committed r141094: <http://trac.webkit.org/changeset/141094>
Comment 4 WebKit Review Bot 2013-01-29 03:57:19 PST
All reviewed patches have been landed.  Closing bug.