Bug 108048
| Summary: | storage/indexeddb tests are crashing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Keishi Hattori <keishi> |
| Component: | Tools / Tests | Assignee: | Joshua Bell <jsbell> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, alecflett, dgrogan, fishd, jsbell, pilgrim |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Keishi Hattori
I rolled out r140602 but it still keeps crashing and I can't figure it out. I am going to mark them as crashing.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Keishi Hattori
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=storage%2Findexeddb%2Fopen-twice-workers.html%2Cstorage%2Findexeddb%2Ftransaction-complete-workers.html%2Cstorage%2Findexeddb%2Fpending-activity-workers.html%2Cstorage%2Findexeddb%2Fcursor-advance-workers.html%2Cstorage%2Findexeddb%2Findex-basics-workers.html%2Cstorage%2Findexeddb%2Ffactory-basics-workers.html%2Cstorage%2Findexeddb%2Fobjectstore-basics-workers.html%2Cstorage%2Findexeddb%2Fdeletedatabase-delayed-by-open-and-versionchange-workers.html
Joshua Bell
This is the suspect change in the range that introduced the crash on all the bots:
http://trac.webkit.org/changeset/140653
Which is a revert of:
http://trac.webkit.org/changeset/140783
But this dependent(?) Chromium change wasn't reverted...
http://src.chromium.org/viewvc/chrome?view=rev&revision=178734
Unfortunately, it's not reproducing for me at the moment. :P Maybe a WebKit/chromium/DEPS roll is involved? I'll keep plugging away at it.
Adam Barth
Ah! Sorry for causing a mess.
Joshua Bell
(In reply to comment #3)
> Ah! Sorry for causing a mess.
My comment was poorly phrased. I don't have proof that's the cause, just a hunch.
"This is *a* suspect change..."
Still can't repro locally, which is itself odd. Alas, alec (who could) is out today.
Joshua Bell
Also, looks like WebKit/chromium/DEPS is at 178434 which is prior to the Chromium rev. The test crashes are also only happening on the ToT bots, not the DEPS bots.
Joshua Bell
My environment must have been mucked up. Reproducing easily now.
Reverting http://src.chromium.org/viewvc/chrome?view=rev&revision=178734 makes the crashes go away reliably as suspected. I'll revert that over on the chromium side.
Joshua Bell
Revert is finally picked up by the WebKit bots and they're starting to cycle green:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=storage%2Findexeddb%2Fopen-twice-workers.html%2Cstorage%2Findexeddb%2Ftransaction-complete-workers.html%2Cstorage%2Findexeddb%2Fpending-activity-workers.html%2Cstorage%2Findexeddb%2Fcursor-advance-workers.html%2Cstorage%2Findexeddb%2Findex-basics-workers.html%2Cstorage%2Findexeddb%2Ffactory-basics-workers.html%2Cstorage%2Findexeddb%2Fobjectstore-basics-workers.html%2Cstorage%2Findexeddb%2Fdeletedatabase-delayed-by-open-and-versionchange-workers.html
Calling this good. I'll revert the other reverts.