Summary: | REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||
Component: | Tools / Tests | Assignee: | David Farler <dfarler> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dbates, ddkilzer, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Rowe (bdash)
2013-01-27 01:21:51 PST
I think I might like to just revert the previous patch entirely and rethink this. Using ARGS= in the makefile and SDKROOT= ARCHS= with build-webkit / xcodebuild, almost everything will work with the same usage as now. Mixing make variables and unparsed Xcode options in $(ARGS) or un-spliced through webkitdirs.pm doesn’t seem worth it. The only problem leftover is reducing the modules lists in Tools/Makefile and Source/Makefile, which I can shore up in a later patch. Created attachment 184909 [details]
Patch
Comment on attachment 184909 [details] Patch Clearing flags on attachment: 184909 Committed r140939: <http://trac.webkit.org/changeset/140939> All reviewed patches have been landed. Closing bug. |