Bug 108018

Summary: Collapse testing for list of PLATFORM() into OS() and USE() tests
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed change none

Laszlo Gombos
Reported 2013-01-26 17:15:41 PST
OS() and USE() tests are preferred over a series of PLATFORM() tests for "for low-level services" - see also the discussion at bug 107406. JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT), PLATFORM(WX) and PLATFORM(GTK), so "PLATFORM(MAC) || PLATFORM(IOS) || (PLATFORM(WX) && OS(DARWIN)) || (PLATFORM(QT) && OS(DARWIN))" can be replaced by "OS(DARWIN) && USE(CF)" which makes the code more readable as well. PLATFORM(MAC), PLATFORM(QT) and PLATFORM(WX) are all enable USE(CF) but not PLATFORM(GTK).
Attachments
proposed change (2.20 KB, patch)
2013-01-26 18:26 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2013-01-26 18:26:49 PST
Created attachment 184893 [details] proposed change
Eric Seidel (no email)
Comment 2 2013-01-28 22:41:34 PST
Comment on attachment 184893 [details] proposed change LGTM.
WebKit Review Bot
Comment 3 2013-01-28 23:01:13 PST
Comment on attachment 184893 [details] proposed change Clearing flags on attachment: 184893 Committed r141059: <http://trac.webkit.org/changeset/141059>
WebKit Review Bot
Comment 4 2013-01-28 23:01:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.