Bug 108018 - Collapse testing for list of PLATFORM() into OS() and USE() tests
Summary: Collapse testing for list of PLATFORM() into OS() and USE() tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-26 17:15 PST by Laszlo Gombos
Modified: 2013-01-28 23:01 PST (History)
3 users (show)

See Also:

Attachments
proposed change (2.20 KB, patch)
2013-01-26 18:26 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2013-01-26 17:15:41 PST 
OS() and USE() tests are preferred over a series of PLATFORM() tests for "for low-level services" - see also the discussion at bug 107406.

JavaScriptCore for OS(DARWIN) is used by PLATFORM(MAC), PLATFORM(QT), PLATFORM(WX) and PLATFORM(GTK), so "PLATFORM(MAC) || PLATFORM(IOS) || (PLATFORM(WX) && OS(DARWIN)) || (PLATFORM(QT) && OS(DARWIN))" can be replaced by "OS(DARWIN) && USE(CF)" which makes the code more readable as well.

PLATFORM(MAC), PLATFORM(QT) and PLATFORM(WX) are all enable USE(CF) but not PLATFORM(GTK).
Comment 1 Laszlo Gombos 2013-01-26 18:26:49 PST 
Created attachment 184893 [details]
proposed change
Comment 2 Eric Seidel (no email) 2013-01-28 22:41:34 PST 
Comment on attachment 184893 [details]
proposed change

LGTM.
Comment 3 WebKit Review Bot 2013-01-28 23:01:13 PST 
Comment on attachment 184893 [details]
proposed change

Clearing flags on attachment: 184893

Committed r141059: <http://trac.webkit.org/changeset/141059>
Comment 4 WebKit Review Bot 2013-01-28 23:01:17 PST 
All reviewed patches have been landed.  Closing bug.