Summary: | [chromium] Export ResourceRequest's priority through WebURLRequest | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Simonsen <simonjam> | ||||||||
Component: | New Bugs | Assignee: | James Simonsen <simonjam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, japhet, peter+ews, tkent+wkapi, webkit.review.bot, willchan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
James Simonsen
2013-01-25 14:34:25 PST
Created attachment 184812 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 184812 [details] Patch Attachment 184812 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16116557 Comment on attachment 184812 [details] Patch Attachment 184812 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16118535 Created attachment 184814 [details]
Patch
Comment on attachment 184814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184814&action=review > Source/WebCore/platform/chromium/support/WebURLRequest.cpp:329 > + switch (m_private->m_resourceRequest->priority()) { We usually just use a static_cast rather than a switch. Also, we use AssertMatchignEnums.cpp to make sure that the WebCore enums stay in sync with the API enums. (Aside from those mechanistic issues, this patch looks fine.) Created attachment 184849 [details]
Patch
(In reply to comment #6) > (From update of attachment 184814 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184814&action=review > > > Source/WebCore/platform/chromium/support/WebURLRequest.cpp:329 > > + switch (m_private->m_resourceRequest->priority()) { > > We usually just use a static_cast rather than a switch. Also, we use AssertMatchignEnums.cpp to make sure that the WebCore enums stay in sync with the API enums. Thanks for the tip. Done. Comment on attachment 184849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184849&action=review > Source/WebCore/platform/chromium/support/WebURLRequest.cpp:330 > + return static_cast<WebURLRequest::Priority>( > + m_private->m_resourceRequest->priority()); We'd normally put this on one line. (There is no 80 col limit in WebKit.) Comment on attachment 184849 [details] Patch Clearing flags on attachment: 184849 Committed r140906: <http://trac.webkit.org/changeset/140906> All reviewed patches have been landed. Closing bug. |