Bug 107968

Summary: Enable running tests on Windows EWS Bots
Product: WebKit Reporter: Lucas Forschler <lforschler>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: REOPENED    
Severity: Normal CC: abarth, dpranke, eric, roger_fong, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 108422, 107969, 108353    
Bug Blocks:    
Attachments:
Description Flags
Enable tests on Win EWS
none
patch for review webkit.review.bot: commit-queue-

Lucas Forschler
Reported 2013-01-25 11:40:42 PST
We have more hardware in the Windows EWS queue. Let's enable running tests and see how it does.
Attachments
Enable tests on Win EWS (1.12 KB, patch)
2013-01-25 11:43 PST, Lucas Forschler 		no flags
DetailsFormatted DiffDiff
patch for review (1.14 KB, patch)
2013-01-25 11:49 PST, Lucas Forschler 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lucas Forschler
Comment 1 2013-01-25 11:41:01 PST
Looking at the Win7 testers on build.webkit.org, I think we should probably get our results in shape before we enable tests.
Lucas Forschler
Comment 2 2013-01-25 11:43:53 PST
Created attachment 184784 [details] Enable tests on Win EWS Patch for review.
WebKit Review Bot
Comment 3 2013-01-25 11:46:58 PST
Attachment 184784 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py']" exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Lucas Forschler
Comment 4 2013-01-25 11:49:09 PST
Created attachment 184788 [details] patch for review Updated Changelog to include bug number.
Adam Barth
Comment 5 2013-01-25 17:15:19 PST
I didn't mark this cq+ because you'll likely want to be around when this lands to make sure it works. :)
Tim Horton
Comment 6 2013-01-29 18:07:02 PST
Comment on attachment 184788 [details] patch for review We're all here! Let's see what happens.
WebKit Review Bot
Comment 7 2013-01-29 18:45:01 PST
Comment on attachment 184788 [details] patch for review Clearing flags on attachment: 184788 Committed r141205: <http://trac.webkit.org/changeset/141205>
WebKit Review Bot
Comment 8 2013-01-29 18:45:04 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 9 2013-01-30 10:22:30 PST
Re-opened since this is blocked by bug 108353
WebKit Review Bot
Comment 10 2013-01-30 16:53:13 PST
Comment on attachment 184788 [details] patch for review Rejecting attachment 184788 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'validate-changelog', '--non-interactive', 184788, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16250040
Roger Fong
Comment 11 2013-01-30 17:24:54 PST
Commited: http://trac.webkit.org/changeset/141349 fingers crossed
WebKit Review Bot
Comment 12 2013-01-30 21:00:49 PST
Re-opened since this is blocked by bug 108422
Roger Fong
Comment 13 2013-02-01 12:48:54 PST
Tried again: http://trac.webkit.org/changeset/141631
Note You need to log in before you can comment on or make changes to this bug.