Summary: | Enable running tests on Windows EWS Bots | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lucas Forschler <lforschler> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | REOPENED --- | ||||||||
Severity: | Normal | CC: | abarth, dpranke, eric, roger_fong, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 108422, 107969, 108353 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Lucas Forschler
2013-01-25 11:40:42 PST
Looking at the Win7 testers on build.webkit.org, I think we should probably get our results in shape before we enable tests. Created attachment 184784 [details]
Enable tests on Win EWS
Patch for review.
Attachment 184784 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py']" exit_code: 1
Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 184788 [details]
patch for review
Updated Changelog to include bug number.
I didn't mark this cq+ because you'll likely want to be around when this lands to make sure it works. :) Comment on attachment 184788 [details]
patch for review
We're all here! Let's see what happens.
Comment on attachment 184788 [details] patch for review Clearing flags on attachment: 184788 Committed r141205: <http://trac.webkit.org/changeset/141205> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 108353 Comment on attachment 184788 [details] patch for review Rejecting attachment 184788 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'validate-changelog', '--non-interactive', 184788, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16250040 Commited: http://trac.webkit.org/changeset/141349 fingers crossed Re-opened since this is blocked by bug 108422 Tried again: http://trac.webkit.org/changeset/141631 |