| Summary: | Adding a text track should not make controls visible | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dglazkov, feature-media-reviews, ojan.autocc, webkit-bug-importer, webkit.review.bot | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 43668 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Eric Carlson
2013-01-25 09:34:19 PST
Created attachment 184767 [details]
Proposed patch
Created attachment 184791 [details]
Updated patch.
Updated patch as the first version sometimes creates hidden controls when we did not previously. This isn't really a change in functionality, but it causes some tests that dump the render tree to fail so attempt to restore the previous behavior.
Not marking r? so the bots can chew on it first.
Comment on attachment 184791 [details] Updated patch. Attachment 184791 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16122473 New failing tests: media/media-captions-no-controls.html Created attachment 184801 [details]
Updated patch.
Oops, the results for my new test depended on the side effect I removed in the second patch :-O
Comment on attachment 184801 [details] Updated patch. Committed r140862. |