| Summary: | [Qt][WK1] Reflect recursion limit and loop checks also for list conversions. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Brüning <michael.bruning> | ||||
| Component: | New Bugs | Assignee: | Michael Brüning <michael.bruning> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | allan.jensen, hausmann, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Michael Brüning
2013-01-25 07:13:21 PST
Created attachment 184747 [details]
Patch
Attachment 184747 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bridge/qt/qt_runtime.cpp']" exit_code: 1
Source/WebCore/bridge/qt/qt_runtime.cpp:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 184747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184747&action=review Good catch. Lists and objects need to be tracked. > Source/WebCore/ChangeLog:3 > + [Qt][WK1] Reflect recursion limit and loop checks als for list conversions. typo: als->also Comment on attachment 184747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184747&action=review Good catch. Lists and objects need to be tracked. > Source/WebCore/ChangeLog:3 > + [Qt][WK1] Reflect recursion limit and loop checks als for list conversions. typo: als->also Committed r141085: <http://trac.webkit.org/changeset/141085> |