Bug 107946

Summary: Web Inspector: Cleanup console.* API MessageSource/Levels.
Product: WebKit Reporter: Mike West <mkwst>
Component: Web Inspector (Deprecated)Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Mike West 2013-01-25 06:40:56 PST
I have a few suggestions:

* console.timeEnd and console.count should both come from ConsoleAPIMessageSource.
* console.count should be DebugMessageLevel (to match console.timeEnd)
* console.profile and console.profileEnd should come from ConsoleAPIMessageSource, and be DebugMessageLevel
Comment 1 Mike West 2013-01-25 07:06:52 PST
Created attachment 184745 [details]
Patch
Comment 2 Mike West 2013-01-25 08:27:08 PST
Comment on attachment 184745 [details]
Patch

Thanks, Pavel.
Comment 3 WebKit Review Bot 2013-01-25 08:32:38 PST
Comment on attachment 184745 [details]
Patch

Clearing flags on attachment: 184745

Committed r140830: <http://trac.webkit.org/changeset/140830>
Comment 4 WebKit Review Bot 2013-01-25 08:32:41 PST
All reviewed patches have been landed.  Closing bug.