Bug 107940 – Web Inspector: remove unused isElement and similar methods from HeapProfiler

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Yury Semikhatsky]

Some of these methods are unused, others make sense only for JS heap snapshots. Also we can simplify filters mechanism used with node/edges providers in the heap profiler.

[Yury Semikhatsky]

Created attachment 184734 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 184734 [details]
Patch

lgtm

[Vsevolod Vlasov]

Comment on attachment 184734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184734&action=review

> Source/WebCore/inspector/front-end/JSHeapSnapshot.js:74
> +        return function(edge) {

{ on a separate line.
Maybe rewrite like this:
function funcName(...)
{
 ... 
}

return funcName;

> Source/WebCore/inspector/front-end/JSHeapSnapshot.js:78
> +                return true

;

[Yury Semikhatsky]

(In reply to comment #3)
> (From update of attachment 184734 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184734&action=review
> 
> > Source/WebCore/inspector/front-end/JSHeapSnapshot.js:74
> > +        return function(edge) {
> 
> { on a separate line.
> Maybe rewrite like this:
> function funcName(...)
> {
>  ... 
> }
> 
> return funcName;
> 
Done.

> > Source/WebCore/inspector/front-end/JSHeapSnapshot.js:78
> > +                return true
> 
> ;
Done.

[Yury Semikhatsky]

Committed r140953: <http://trac.webkit.org/changeset/140953>