Bug 107938

Summary: Refactor InspectorMemoryAgent: memory data as a map.
Product: WebKit Reporter: Marja Hölttä <marja>
Component: Web Inspector (Deprecated)Assignee: Marja Hölttä <marja>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107651    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Marja Hölttä 2013-01-25 05:09:26 PST 
This will be used by bug 107651 which adds a WebKit API for accessing the memory information collected by the inspector.
Comment 1 Marja Hölttä 2013-01-25 05:12:16 PST 
Created attachment 184730 [details]
Patch
Comment 2 Marja Hölttä 2013-01-25 05:13:46 PST 
Created attachment 184731 [details]
Patch
Comment 3 Yury Semikhatsky 2013-01-25 05:33:01 PST 
Comment on attachment 184731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184731&action=review

> Source/WebCore/inspector/InspectorController.cpp:449
> +    m_memoryAgent->getProcessMemoryDistributionAsMap(0, graph, &memoryInfo);

0 -> false
Comment 4 Marja Hölttä 2013-01-25 05:34:17 PST 
Created attachment 184735 [details]
Patch
Comment 5 Marja Hölttä 2013-01-25 05:34:37 PST 
Comment on attachment 184731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184731&action=review

>> Source/WebCore/inspector/InspectorController.cpp:449
>> +    m_memoryAgent->getProcessMemoryDistributionAsMap(0, graph, &memoryInfo);
> 
> 0 -> false

Oops! Fixed.
Comment 6 WebKit Review Bot 2013-01-25 06:38:53 PST 
Comment on attachment 184735 [details]
Patch

Clearing flags on attachment: 184735

Committed r140823: <http://trac.webkit.org/changeset/140823>
Comment 7 WebKit Review Bot 2013-01-25 06:38:59 PST 
All reviewed patches have been landed.  Closing bug.