Bug 107918

Summary: INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, morrita, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107897    
Attachments:
Description Flags
Patch haraken: review+

Description Kent Tamura 2013-01-24 22:58:20 PST 
INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement
Comment 1 Kent Tamura 2013-01-24 23:09:48 PST 
Created attachment 184675 [details]
Patch
Comment 2 Kentaro Hara 2013-01-24 23:18:00 PST 
Comment on attachment 184675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184675&action=review

Looks OK.

> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:97
> +    DateTimeFieldElement::initialize(pseudo, axHelpText, m_minimumIndex + 1, m_maximumIndex + 1);

You might want to add a comment why you are passing +1 values (if you want). That looks mysterious to strangers.
Comment 3 Kent Tamura 2013-01-24 23:31:11 PST 
Comment on attachment 184675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184675&action=review

>> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:97
>> +    DateTimeFieldElement::initialize(pseudo, axHelpText, m_minimumIndex + 1, m_maximumIndex + 1);
> 
> You might want to add a comment why you are passing +1 values (if you want). That looks mysterious to strangers.

ok, I'll add a comment.
Comment 4 Kent Tamura 2013-01-24 23:59:08 PST 
Committed r140791: <http://trac.webkit.org/changeset/140791>