Bug 107918

Summary: INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, morrita, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107897    
Attachments:
Description Flags
Patch haraken: review+

Kent Tamura
Reported 2013-01-24 22:58:20 PST
INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement
Attachments
Patch (8.48 KB, patch)
2013-01-24 23:09 PST, Kent Tamura 		haraken: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2013-01-24 23:09:48 PST
Created attachment 184675 [details] Patch
Kentaro Hara
Comment 2 2013-01-24 23:18:00 PST
Comment on attachment 184675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184675&action=review Looks OK. > Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:97 > + DateTimeFieldElement::initialize(pseudo, axHelpText, m_minimumIndex + 1, m_maximumIndex + 1); You might want to add a comment why you are passing +1 values (if you want). That looks mysterious to strangers.
Kent Tamura
Comment 3 2013-01-24 23:31:11 PST
Comment on attachment 184675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184675&action=review >> Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp:97 >> + DateTimeFieldElement::initialize(pseudo, axHelpText, m_minimumIndex + 1, m_maximumIndex + 1); > > You might want to add a comment why you are passing +1 values (if you want). That looks mysterious to strangers. ok, I'll add a comment.
Kent Tamura
Comment 4 2013-01-24 23:59:08 PST
Committed r140791: <http://trac.webkit.org/changeset/140791>
Note You need to log in before you can comment on or make changes to this bug.