Summary: | Coordinated Graphics: Refactor code related to debug border and repaint count. | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dongseong Hwang <dongseong.hwang> | ||||||||||||||||||
Component: | Layout and Rendering | Assignee: | Dongseong Hwang <dongseong.hwang> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | benjamin, noam, webkit-ews, webkit.review.bot, zeno | ||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Bug Depends on: | 105787 | ||||||||||||||||||||
Bug Blocks: | 107198 | ||||||||||||||||||||
Attachments: |
|
Description
Dongseong Hwang
2013-01-24 21:30:12 PST
Created attachment 184657 [details]
Patch
I did not change WK2 part. See Bug 105787#c54 and Bug 105787#c55 Comment on attachment 184657 [details] Patch Attachment 184657 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16111466 Comment on attachment 184657 [details] Patch Attachment 184657 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16110642 Created attachment 185059 [details]
Patch
This patch was already reviewed by noam in Bug 105787. I separated WK2 part in this bug. Comment on attachment 185059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185059&action=review I have nothing against this for WebKit2. Please have No'am review it. > Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:165 > + HashMap<uint32_t, CoordinatedBackingStoreTile>::iterator end = m_tiles.end(); > + for (HashMap<uint32_t, CoordinatedBackingStoreTile>::iterator it = m_tiles.begin(); it != end; ++it) Looks like your hashmap is desperate to get a typedef :) > Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:74 > + WebCore::FloatRect rect() const { return WebCore::FloatRect(WebCore::FloatPoint::zero(), m_size); } This name seems too generic. I have no idea what is a rect for a backing store. (In reply to comment #7) > (From update of attachment 185059 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185059&action=review > > I have nothing against this for WebKit2. Please have No'am review it. Thank you for review! I ask noam :) > Looks like your hashmap is desperate to get a typedef :) I'll use typedef! > > Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:74 > > + WebCore::FloatRect rect() const { return WebCore::FloatRect(WebCore::FloatPoint::zero(), m_size); } > > This name seems too generic. I have no idea what is a rect for a backing store. This method matches to TextureMapperTiledBackingStore::rect(). rect is contents rect of a backing store. noam, is it better to change name? something like contentsRect? Created attachment 185093 [details]
Patch
Created attachment 185094 [details]
Patch
Created attachment 185104 [details]
Patch
noam, benjaminp agreed on this patch. could you review again? :) Comment on attachment 185104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185104&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:380 > + Line not necessary > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:390 > + Ditto Created attachment 185157 [details]
Patch for landing
Created attachment 185160 [details]
Patch for landing
Created attachment 185161 [details]
Patch for landing
Comment on attachment 185161 [details] Patch for landing Clearing flags on attachment: 185161 Committed r141065: <http://trac.webkit.org/changeset/141065> All reviewed patches have been landed. Closing bug. |