Bug 107897

Summary: INPUT_MULTIPLE_FIELDS_UI: Inconsistent value of aria-valuetext attribute
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, morrita, ojan.autocc, webkit.review.bot, yosin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 107915, 107918    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Kent Tamura 2013-01-24 19:19:24 PST 
1. Open a document with <input type=date>.
2. Check aria-valuetext attribute of shadow nodes.
  ==> -webkit-datetime-edit-*-field elements have no aria-valuetext attribute
3. Put a number to a field.  e.g. put "2013" to a year field
  ==> -webkit-datetime-edit-*-field has aria-valuetext="2013"
4. Delete the number in the field by Backspace key
  ==> -webkit-datetime-edit-*-field has aria-valuetext="blank"

aria-valuetext should be consistent in the step 2 and step 4 above.
Comment 1 Kent Tamura 2013-01-24 19:26:50 PST 
aria-valuenow is also inconsistent.
 Step 2: No aria-valuenow attribute
 Step 4: aria-valuenow="yyyy"
Comment 2 Kent Tamura 2013-01-24 19:52:01 PST 
http://www.w3.org/TR/wai-aria/states_and_properties#aria-valuenow

According to the specification, we should remove aria-valuenow attribute in Step 4.
I think aria-valuetext should be "blank" in Step 2.
Comment 3 Kent Tamura 2013-01-24 21:06:58 PST 
Also, aria-valuenow should be a number.  We set non-numbers for AM/PM field.
Comment 4 Kent Tamura 2013-01-25 00:48:41 PST 
Created attachment 184690 [details]
Patch
Comment 5 Kentaro Hara 2013-01-25 01:23:58 PST 
Comment on attachment 184690 [details]
Patch

Looks good to me
Comment 6 WebKit Review Bot 2013-01-25 02:12:17 PST 
Comment on attachment 184690 [details]
Patch

Clearing flags on attachment: 184690

Committed r140803: <http://trac.webkit.org/changeset/140803>
Comment 7 WebKit Review Bot 2013-01-25 02:12:20 PST 
All reviewed patches have been landed.  Closing bug.