Bug 107896

Summary:

[wk2] Page overlays should do their own animation, instead of relying on implicit animation

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebKit2

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, sam, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	sam: review+

Description Tim Horton 2013-01-24 19:16:38 PST

Right now, with TiledCoreAnimationDrawingArea, we accidentally depend on CA implicit animation to do the fade animation when removing a page overlay; we don't use PageOverlay's fade animation (which should be adjusted to use a CA explicit animation, but that's a bug for another day) on the way out (but we do on the way in!). We should make this consistent and update callers.

<rdar://problem/12900058>

Comment 1 Tim Horton 2013-01-24 19:32:17 PST

Created attachment 184641 [details]
patch

Comment 2 Tim Horton 2013-01-24 19:49:02 PST

http://trac.webkit.org/changeset/140769