Summary: | Abort parsing when pending location change for threaded HTML parser | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||
Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, ojan.autocc, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 106127 | ||||||
Attachments: |
|
Description
Tony Gentilcore
2013-01-24 16:29:34 PST
Created attachment 184606 [details]
Patch
Comment on attachment 184606 [details]
Patch
So this just makes us ignore the rest of this token batch. I assume other bits cause the parser to actually stop. It's still lame that we have to poll teh frame for this and it can't just tell us to stop!
(In reply to comment #2) > (From update of attachment 184606 [details]) > So this just makes us ignore the rest of this token batch. I assume other bits cause the parser to actually stop. Right > It's still lame that we have to poll teh frame for this and it can't just tell us to stop! Yeah, there's a FIXME by the other callsite. We should clean it up, but this is no worse than the main thread parser for now. Comment on attachment 184606 [details] Patch Rejecting attachment 184606 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 184606, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Eric Seidel']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patch: **** Can't create file /tmp/pp3gjd7X : No space left on device patch: **** Can't create file /tmp/pplM8QPX : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Eric Seidel']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16097597 Comment on attachment 184606 [details] Patch Clearing flags on attachment: 184606 Committed r140842: <http://trac.webkit.org/changeset/140842> All reviewed patches have been landed. Closing bug. |