Bug 107865

Summary:

CertificateChain functions in ResourceResponse should be inside proper ifdefs

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

Platform

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, beidson, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	beidson: review+

Description Pratik Solanki 2013-01-24 14:34:38 PST

ResourceResponse::setCertificateChain() and ResourceResponse::certificateChain() are declared inside #if PLATFORM(MAC || USE(CFNETWORK) but the definition is inside !USE(CFNETWORK). We should put it in the proper ifdef.

Comment 1 Pratik Solanki 2013-01-24 14:37:29 PST

Created attachment 184580 [details]
Patch

Comment 2 Brady Eidson 2013-01-24 14:38:44 PST

Comment on attachment 184580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184580&action=review

> Source/WebCore/platform/network/mac/ResourceResponseMac.mm:192
>  
> -#endif // USE(CFNETWORK)
> +#endif

I'm sure you meant to add "// PLATFORM(MAC) || USE(CFNETWORK)"  :)

Comment 3 Pratik Solanki 2013-01-24 15:29:44 PST

Committed r140738: <http://trac.webkit.org/changeset/140738>