Bug 107865

Summary: CertificateChain functions in ResourceResponse should be inside proper ifdefs
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: PlatformAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, psolanki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch beidson: review+

Pratik Solanki
Reported 2013-01-24 14:34:38 PST
ResourceResponse::setCertificateChain() and ResourceResponse::certificateChain() are declared inside #if PLATFORM(MAC || USE(CFNETWORK) but the definition is inside !USE(CFNETWORK). We should put it in the proper ifdef.
Attachments
Patch (1.81 KB, patch)
2013-01-24 14:37 PST, Pratik Solanki 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2013-01-24 14:37:29 PST
Created attachment 184580 [details] Patch
Brady Eidson
Comment 2 2013-01-24 14:38:44 PST
Comment on attachment 184580 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184580&action=review > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:192 > > -#endif // USE(CFNETWORK) > +#endif I'm sure you meant to add "// PLATFORM(MAC) || USE(CFNETWORK)" :)
Pratik Solanki
Comment 3 2013-01-24 15:29:44 PST
Committed r140738: <http://trac.webkit.org/changeset/140738>
Note You need to log in before you can comment on or make changes to this bug.