Bug 107852

Summary: Allow some plugin snapshot UI content to come from Injected Bundle
Product: WebKit Reporter: Dean Jackson <dino>
Component: Plug-insAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, buildbot, jonlee, rniwa, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Description Dean Jackson 2013-01-24 11:56:13 PST
The snapshotted plugin UI might have some custom appearance provided by the RenderTheme (for example). Allow the Injected Bundle to expose a title, subtitle and potentially come custom CSS for when the snapshot uses a shadow DOM.
Comment 1 Radar WebKit Bug Importer 2013-01-24 11:56:31 PST
<rdar://problem/13079786>
Comment 2 Dean Jackson 2013-01-24 12:06:37 PST
Created attachment 184550 [details]
Patch
Comment 3 Build Bot 2013-01-24 12:35:48 PST
Comment on attachment 184550 [details]
Patch

Attachment 184550 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16080829
Comment 4 Dean Jackson 2013-01-24 12:44:45 PST
Created attachment 184555 [details]
Patch
Comment 5 Dean Jackson 2013-01-24 12:45:24 PST
Removed override keyword while I'm actually not overriding anything from the chrome client. That will happen in a subsequent commit.
Comment 6 Dean Jackson 2013-01-24 13:04:55 PST
Committed r140713: <http://trac.webkit.org/changeset/140713>