Bug 107852

Summary: Allow some plugin snapshot UI content to come from Injected Bundle
Product: WebKit Reporter: Dean Jackson <dino>
Component: Plug-insAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, buildbot, jonlee, rniwa, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Dean Jackson
Reported 2013-01-24 11:56:13 PST
The snapshotted plugin UI might have some custom appearance provided by the RenderTheme (for example). Allow the Injected Bundle to expose a title, subtitle and potentially come custom CSS for when the snapshot uses a shadow DOM.
Attachments
Patch (9.07 KB, patch)
2013-01-24 12:06 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (9.04 KB, patch)
2013-01-24 12:44 PST, Dean Jackson 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-01-24 11:56:31 PST
<rdar://problem/13079786>
Dean Jackson
Comment 2 2013-01-24 12:06:37 PST
Created attachment 184550 [details] Patch
Build Bot
Comment 3 2013-01-24 12:35:48 PST
Comment on attachment 184550 [details] Patch Attachment 184550 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16080829
Dean Jackson
Comment 4 2013-01-24 12:44:45 PST
Created attachment 184555 [details] Patch
Dean Jackson
Comment 5 2013-01-24 12:45:24 PST
Removed override keyword while I'm actually not overriding anything from the chrome client. That will happen in a subsequent commit.
Dean Jackson
Comment 6 2013-01-24 13:04:55 PST
Committed r140713: <http://trac.webkit.org/changeset/140713>
Note You need to log in before you can comment on or make changes to this bug.