Bug 107852 - Allow some plugin snapshot UI content to come from Injected Bundle
Summary: Allow some plugin snapshot UI content to come from Injected Bundle
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Reported: 2013-01-24 11:56 PST by Dean Jackson
Modified: 2013-01-24 13:04 PST (History)
7 users (show)

See Also:

Patch (9.07 KB, patch)
2013-01-24 12:06 PST, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (9.04 KB, patch)
2013-01-24 12:44 PST, Dean Jackson
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-01-24 11:56:13 PST
The snapshotted plugin UI might have some custom appearance provided by the RenderTheme (for example). Allow the Injected Bundle to expose a title, subtitle and potentially come custom CSS for when the snapshot uses a shadow DOM.
Comment 1 Radar WebKit Bug Importer 2013-01-24 11:56:31 PST
Comment 2 Dean Jackson 2013-01-24 12:06:37 PST
Created attachment 184550 [details]
Comment 3 Build Bot 2013-01-24 12:35:48 PST
Comment on attachment 184550 [details]

Attachment 184550 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16080829
Comment 4 Dean Jackson 2013-01-24 12:44:45 PST
Created attachment 184555 [details]
Comment 5 Dean Jackson 2013-01-24 12:45:24 PST
Removed override keyword while I'm actually not overriding anything from the chrome client. That will happen in a subsequent commit.
Comment 6 Dean Jackson 2013-01-24 13:04:55 PST
Committed r140713: <http://trac.webkit.org/changeset/140713>