Summary: | [EFL][WK2] Use C API inside BatteryProvider and NetworkInfoProvider | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sudarsana Nagineni (babu) <naginenis> | ||||||||||
Component: | WebKit EFL | Assignee: | Sudarsana Nagineni (babu) <naginenis> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, benjamin, cdumez, gyuyoung.kim, kenneth, kling, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 107657 | ||||||||||||
Attachments: |
|
Description
Sudarsana Nagineni (babu)
2013-01-24 06:19:25 PST
Created attachment 184507 [details]
Patch
Comment on attachment 184507 [details]
Patch
LGTM
Created attachment 185496 [details]
patch
Rebased.
Comment on attachment 185496 [details]
patch
LGTM.
Comment on attachment 185496 [details]
patch
Looks fine.
Created attachment 187604 [details]
Patch
Rebased on master.
Comment on attachment 187604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187604&action=review > Source/WebKit2/UIProcess/efl/BatteryProvider.cpp:94 > + WKBatteryStatusRef wkBatteryStatus = WKBatteryStatusCreate(status->charging(), status->chargingTime(), status->dischargingTime(), status->level()); So why not WKRetainPtr? Are you releasing it manually later? Comment on attachment 187604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187604&action=review >> Source/WebKit2/UIProcess/efl/BatteryProvider.cpp:94 >> + WKBatteryStatusRef wkBatteryStatus = WKBatteryStatusCreate(status->charging(), status->chargingTime(), status->dischargingTime(), status->level()); > > So why not WKRetainPtr? Are you releasing it manually later? Right. Good catch Kenneth. I also believe you need to adopt the returned value here. > Source/WebKit2/UIProcess/efl/BatteryProvider.cpp:97 > + WKBatteryManagerProviderDidChangeBatteryStatus(m_batteryManager.get(), wkEventType.get(), wkBatteryStatus); Have you tried toAPI(eventType.impl()) ? Comment on attachment 187604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187604&action=review >>> Source/WebKit2/UIProcess/efl/BatteryProvider.cpp:94 >>> + WKBatteryStatusRef wkBatteryStatus = WKBatteryStatusCreate(status->charging(), status->chargingTime(), status->dischargingTime(), status->level()); >> >> So why not WKRetainPtr? Are you releasing it manually later? > > Right. Good catch Kenneth. I also believe you need to adopt the returned value here. Okay. >> Source/WebKit2/UIProcess/efl/BatteryProvider.cpp:97 >> + WKBatteryManagerProviderDidChangeBatteryStatus(m_batteryManager.get(), wkEventType.get(), wkBatteryStatus); > > Have you tried toAPI(eventType.impl()) ? I have not, but I will check it. Created attachment 187877 [details]
Patch
Take comments from Kenneth and Chris into consideration.
Comment on attachment 187877 [details]
Patch
LGTM
Comment on attachment 187877 [details] Patch Clearing flags on attachment: 187877 Committed r143008: <http://trac.webkit.org/changeset/143008> All reviewed patches have been landed. Closing bug. |