Summary: | Web Inspector: implement search for workspace sources | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Lushnikov <lushnikov> | ||||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Lushnikov <lushnikov> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Andrey Lushnikov
2013-01-24 05:41:02 PST
Created attachment 184472 [details]
Patch
Comment on attachment 184472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184472&action=review > Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js:96 > + function contentCallback(content, base64Encoded, mimeType) Please annotate. > Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js:99 > + var lines = content.split("\n"); You either need lines or lineEndings. > Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js:102 > + for (var i = 0; i < lines.length; ++i) { Please extract this code. Created attachment 184495 [details]
Patch
Comment on attachment 184495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184495&action=review > Source/WebCore/inspector/front-end/ContentProviders.js:291 > callback(result); no need for intermediate result variable. > Source/WebCore/inspector/front-end/utilities.js:646 > +function performSearchInContent(content, query, caseSensitive, isRegex) utilities are non-WebInspector aware. This should be defined next to WebInspector.ContentProvider.SearchMatch. Created attachment 184497 [details]
Patch
Created attachment 184502 [details]
Patch
Comment on attachment 184502 [details] Patch Rejecting attachment 184502 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 184502, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: webkit-commit-queue Parsed 4 diffs from patch file(s). patch: **** Can't create file /tmp/ppu5M6MG : No space left on device patch: **** Can't create file /tmp/ppxbXQiF : No space left on device patch: **** Can't create file /tmp/ppa1jDZE : No space left on device patch: **** Can't create file /tmp/pp13mTbF : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Pavel Feldman']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16078781 Created attachment 184697 [details]
Patch
Comment on attachment 184697 [details] Patch Clearing flags on attachment: 184697 Committed r140809: <http://trac.webkit.org/changeset/140809> All reviewed patches have been landed. Closing bug. |