Bug 107803

Summary:

[Qt] Build is KO since r140610 (QString::fromUTF16 function does not exist)

Product:

WebKit

Reporter:

Julien Brianceau <jbriance>

Component:

XML

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

mrobinson, webkit.review.bot, zarvai

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix Qt QString::fromUtf16() function call	none

Julien Brianceau

Reported 2013-01-24 01:35:14 PST

Qt SH4 build slave (http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release) doesn't build since r140610 There is a typo error for QString::fromUtf16 call. It is fromUtf16 and not fromUTF16 in Qt.

Attachments
Fix Qt QString::fromUtf16() function call (1.35 KB, patch) 2013-01-24 01:51 PST, Julien Brianceau	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Julien Brianceau

Comment 1 2013-01-24 01:51:55 PST

Created attachment 184440 [details] Fix Qt QString::fromUtf16() function call

Andreas Kling

Comment 2 2013-01-24 01:57:44 PST

Comment on attachment 184440 [details] Fix Qt QString::fromUtf16() function call rs=me

WebKit Review Bot

Comment 3 2013-01-24 03:27:22 PST

Comment on attachment 184440 [details] Fix Qt QString::fromUtf16() function call Clearing flags on attachment: 184440 Committed r140671: <http://trac.webkit.org/changeset/140671>

WebKit Review Bot

Comment 4 2013-01-24 03:27:25 PST

All reviewed patches have been landed. Closing bug.

Zoltan Arvai

Comment 5 2013-01-24 05:22:17 PST

A problem still exists with QString::fromUtf16 usage on windows bot: http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Release/builds/60904/steps/compile-webkit/logs/stdio C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebCore\xml\parser\XMLDocumentParserQt.cpp(74) : error C2664: 'QString::fromUtf16' : cannot convert parameter 1 from 'UChar [4]' to 'const ushort *' Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast Can you take a look at the conversation issue, please?

Martin Robinson

Comment 6 2013-01-24 05:59:46 PST

Sorry for the breakage. It's odd that the EWS did not catch this.

Zoltan Arvai

Comment 7 2013-01-24 06:31:04 PST

(In reply to comment #6) > Sorry for the breakage. It's odd that the EWS did not catch this. Maybe Win EWS uses MINGW while Qt Win bot uses MSVC for build.

Note You need to log in before you can comment on or make changes to this bug.