| Summary: | Web Inspector: breakpoints are not restored upon reload for scripts with script mapping. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Pavel Feldman
2013-01-24 00:57:20 PST
Created attachment 184432 [details]
Patch
Comment on attachment 184432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184432&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:116 > + var uiSourceCode = /** @type {WebInspector.UISourceCode} */ (event.target); Can this fire several times per the same UISourceCode? I'm wary of duplicate breakpoints, actually. Comment on attachment 184432 [details] Patch Rejecting attachment 184432 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 184432, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16021038 Committed r140666: <http://trac.webkit.org/changeset/140666> |