Bug 107799 – Web Inspector: breakpoints are not restored upon reload for scripts with script mapping.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

The problem is that source mapping is set after UISourceCode gets into the workspace.

[Pavel Feldman]

Created attachment 184432 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 184432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184432&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:116
> +        var uiSourceCode = /** @type {WebInspector.UISourceCode} */ (event.target);

Can this fire several times per the same UISourceCode? I'm wary of duplicate breakpoints, actually.

[WebKit Review Bot]

Comment on attachment 184432 [details]
Patch

Rejecting attachment 184432 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 184432, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16021038

[Pavel Feldman]

Committed r140666: <http://trac.webkit.org/changeset/140666>