Bug 107799 - Web Inspector: breakpoints are not restored upon reload for scripts with script mapping.
Summary: Web Inspector: breakpoints are not restored upon reload for scripts with scri...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2013-01-24 00:57 PST by Pavel Feldman
Modified: 2013-01-24 01:21 PST (History)
9 users (show)

See Also:

Patch (5.91 KB, patch)
2013-01-24 01:00 PST, Pavel Feldman
apavlov: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2013-01-24 00:57:20 PST
The problem is that source mapping is set after UISourceCode gets into the workspace.
Comment 1 Pavel Feldman 2013-01-24 01:00:57 PST
Created attachment 184432 [details]
Comment 2 Alexander Pavlov (apavlov) 2013-01-24 01:03:35 PST
Comment on attachment 184432 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=184432&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:116
> +        var uiSourceCode = /** @type {WebInspector.UISourceCode} */ (event.target);

Can this fire several times per the same UISourceCode? I'm wary of duplicate breakpoints, actually.
Comment 3 WebKit Review Bot 2013-01-24 01:17:16 PST
Comment on attachment 184432 [details]

Rejecting attachment 184432 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 184432, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16021038
Comment 4 Pavel Feldman 2013-01-24 01:21:53 PST
Committed r140666: <http://trac.webkit.org/changeset/140666>