RESOLVED FIXED 107799
Web Inspector: breakpoints are not restored upon reload for scripts with script mapping. 
https://bugs.webkit.org/show_bug.cgi?id=107799
Summary Web Inspector: breakpoints are not restored upon reload for scripts with scri...
Pavel Feldman
Reported 2013-01-24 00:57:20 PST
The problem is that source mapping is set after UISourceCode gets into the workspace.
Attachments
Patch (5.91 KB, patch)
2013-01-24 01:00 PST, Pavel Feldman 		apavlov: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2013-01-24 01:00:57 PST
Created attachment 184432 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2013-01-24 01:03:35 PST
Comment on attachment 184432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184432&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:116 > + var uiSourceCode = /** @type {WebInspector.UISourceCode} */ (event.target); Can this fire several times per the same UISourceCode? I'm wary of duplicate breakpoints, actually.
WebKit Review Bot
Comment 3 2013-01-24 01:17:16 PST
Comment on attachment 184432 [details] Patch Rejecting attachment 184432 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 184432, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16021038
Pavel Feldman
Comment 4 2013-01-24 01:21:53 PST
Committed r140666: <http://trac.webkit.org/changeset/140666>
Note You need to log in before you can comment on or make changes to this bug.