Bug 107769

Summary: Consider all ancestors not just parentElement when disconnecting frames
Product: WebKit Reporter: Elliott Sprehn <esprehn>
Component: New BugsAssignee: Elliott Sprehn <esprehn>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Elliott Sprehn
Reported 2013-01-23 17:49:55 PST
Consider all ancestors not just parentElement when disconnecting frames
Attachments
Patch (4.10 KB, patch)
2013-01-23 17:52 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (7.35 KB, patch)
2013-01-25 11:45 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Elliott Sprehn
Comment 1 2013-01-23 17:52:50 PST
Created attachment 184368 [details] Patch WIP, needs a non-manual test.
Eric Seidel (no email)
Comment 2 2013-01-23 22:22:57 PST
Comment on attachment 184368 [details] Patch Does this change behavior? Tests?
Elliott Sprehn
Comment 3 2013-01-23 22:25:50 PST
(In reply to comment #2) > (From update of attachment 184368 [details]) > Does this change behavior? Tests? Yeah it does, I have a test but I need to change it from console.logs to a layout test. :)
Elliott Sprehn
Comment 4 2013-01-25 11:45:33 PST
Created attachment 184786 [details] Patch
Eric Seidel (no email)
Comment 5 2013-01-25 11:53:44 PST
Comment on attachment 184786 [details] Patch LGTM.
WebKit Review Bot
Comment 6 2013-01-25 12:15:02 PST
Comment on attachment 184786 [details] Patch Clearing flags on attachment: 184786 Committed r140856: <http://trac.webkit.org/changeset/140856>
WebKit Review Bot
Comment 7 2013-01-25 12:15:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.