Bug 107769 - Consider all ancestors not just parentElement when disconnecting frames
Summary: Consider all ancestors not just parentElement when disconnecting frames
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Sprehn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-23 17:49 PST by Elliott Sprehn
Modified: 2013-01-25 12:15 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.10 KB, patch)
2013-01-23 17:52 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Patch (7.35 KB, patch)
2013-01-25 11:45 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Sprehn 2013-01-23 17:49:55 PST 
Consider all ancestors not just parentElement when disconnecting frames
Comment 1 Elliott Sprehn 2013-01-23 17:52:50 PST 
Created attachment 184368 [details]
Patch

WIP, needs a non-manual test.
Comment 2 Eric Seidel (no email) 2013-01-23 22:22:57 PST 
Comment on attachment 184368 [details]
Patch

Does this change behavior?  Tests?
Comment 3 Elliott Sprehn 2013-01-23 22:25:50 PST 
(In reply to comment #2)
> (From update of attachment 184368 [details])
> Does this change behavior?  Tests?

Yeah it does, I have a test but I need to change it from console.logs to a layout test. :)
Comment 4 Elliott Sprehn 2013-01-25 11:45:33 PST 
Created attachment 184786 [details]
Patch
Comment 5 Eric Seidel (no email) 2013-01-25 11:53:44 PST 
Comment on attachment 184786 [details]
Patch

LGTM.
Comment 6 WebKit Review Bot 2013-01-25 12:15:02 PST 
Comment on attachment 184786 [details]
Patch

Clearing flags on attachment: 184786

Committed r140856: <http://trac.webkit.org/changeset/140856>
Comment 7 WebKit Review Bot 2013-01-25 12:15:06 PST 
All reviewed patches have been landed.  Closing bug.