Summary: | Teach threaded HTML parser to update InspectorInstrumentation when writing HTML | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||||
Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ojan.autocc, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 106127 | ||||||||
Attachments: |
|
Description
Tony Gentilcore
2013-01-23 16:23:29 PST
Created attachment 184338 [details]
Patch
Comment on attachment 184338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184338&action=review > Source/WebCore/html/parser/HTMLDocumentParser.cpp:284 > + InspectorInstrumentationCookie cookie = InspectorInstrumentation::willWriteHTML(document(), 0, 0); We have the line number, we could easily pass it here. :) > Source/WebCore/html/parser/HTMLDocumentParser.cpp:313 > + InspectorInstrumentation::didWriteHTML(cookie, 0); Similarly here, lineNumber() should just be correct already. :) Created attachment 184350 [details]
Patch
> Similarly here, lineNumber() should just be correct already. :)
You are right. Fixed.
Comment on attachment 184350 [details]
Patch
LGTM. It would be easy to wire the input length into the "packets of tokens" sent back from the background parser, but we can do that in a second pass.
Comment on attachment 184350 [details] Patch Clearing flags on attachment: 184350 Committed r140628: <http://trac.webkit.org/changeset/140628> All reviewed patches have been landed. Closing bug. |