Bug 107746

Summary: Convert RenderFullScreen to use the non-deprecated flexbox
Product: WebKit Reporter: Christian Biesinger <cbiesinger>
Component: New BugsAssignee: Christian Biesinger <cbiesinger>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, eric.carlson, eric, feature-media-reviews, jer.noble, macpherson, menard, ojan.autocc, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Christian Biesinger
Reported 2013-01-23 15:16:48 PST
Convert RenderFullScreen to use the non-deprecated flexbox
Attachments
Patch (3.13 KB, patch)
2013-01-23 15:18 PST, Christian Biesinger 		no flags
DetailsFormatted DiffDiff
Patch (14.03 KB, patch)
2013-01-23 16:42 PST, Christian Biesinger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Christian Biesinger
Comment 1 2013-01-23 15:18:52 PST
Created attachment 184325 [details] Patch
Christian Biesinger
Comment 2 2013-01-23 16:42:48 PST
Created attachment 184345 [details] Patch
Christian Biesinger
Comment 3 2013-01-23 16:43:17 PST
new patch also updates the fullscreen-related css/*.css files
Ojan Vafai
Comment 4 2013-01-23 23:11:28 PST
Comment on attachment 184345 [details] Patch Are none of the fullscreen tests render tree dumps? I'd expect some render tree dumps to change here.
Christian Biesinger
Comment 5 2013-01-24 11:59:31 PST
Some (a minority) are render dumps... but I don't see any RenderDeprecatedFlexBox in those dumps, e.g.: http://trac.webkit.org/browser/trunk/LayoutTests/fullscreen/full-screen-render-inline-expected.txt Maybe the ones that do have a render dump don't dump during full screen?
WebKit Review Bot
Comment 6 2013-01-24 12:18:08 PST
Comment on attachment 184345 [details] Patch Clearing flags on attachment: 184345 Committed r140705: <http://trac.webkit.org/changeset/140705>
WebKit Review Bot
Comment 7 2013-01-24 12:18:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.