| Summary: | [Chromium] Remove unused header files in chromium/public/platform/ | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||
| Component: | WebKit Misc. | Assignee: | Mark Pilgrim (Google) <pilgrim> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, haraken, jamesr, jochen, tkent+wkapi, tony, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 82948 | ||||||
| Attachments: |
|
||||||
|
Description
Mark Pilgrim (Google)
2013-01-23 14:46:30 PST
Created attachment 184317 [details]
Patch
*** Bug 106227 has been marked as a duplicate of this bug. *** Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. After 1-1 discussion with fishd, we've decided to abandon the attempt to add Platform/chromium to the dependent_dirs for embedders. All previous patches to that end in Chromium land will be reverted. Header files in WebKit/chromium/public/ will use relative paths to #include header files in Platform/chromium/public/. Sorry about giving you the run-around! It was a good idea that turned out to be more trouble than it was worth. (In reply to comment #4) > After 1-1 discussion with fishd, we've decided to abandon the attempt to add Platform/chromium to the dependent_dirs for embedders. All previous patches to that end in Chromium land will be reverted. Header files in WebKit/chromium/public/ will use relative paths to #include header files in Platform/chromium/public/. Should we do the same for #includes in TestRunner/public including header files in Platform/chromium/public? Then we could remove '../chromium' from the list of include_dirs and direct_dependent_settings in Platform.gyp. (In reply to comment #7) > Should we do the same for #includes in TestRunner/public including header files in Platform/chromium/public? Then we could remove '../chromium' from the list of include_dirs and direct_dependent_settings in Platform.gyp. I would be happy to do that once this patch lands, if there is consensus. Comment on attachment 184317 [details] Patch Clearing flags on attachment: 184317 Committed r140621: <http://trac.webkit.org/changeset/140621> All reviewed patches have been landed. Closing bug. |