Bug 107719

Summary:

[EFL][WK2] Rename EwkViewImpl class to EwkView

Product:

WebKit

Reporter:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Component:

WebKit EFL

Assignee:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, gyuyoung.kim, kenneth, lucas.de.marchi, naginenis, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

107662

Attachments:

Description	Flags
patch	none
patch	kling: review+, webkit.review.bot: commit-queue-

Mikhail Pozdnyakov

Reported 2013-01-23 12:22:43 PST

SSIA. The rational behind the renaming is described at https://bugs.webkit.org/show_bug.cgi?id=107662#c1

Attachments
patch (191.09 KB, patch) 2013-01-23 13:20 PST, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
patch (191.32 KB, patch) 2013-01-24 00:31 PST, Mikhail Pozdnyakov	kling: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mikhail Pozdnyakov

Comment 1 2013-01-23 13:20:20 PST

Created attachment 184295 [details] patch

Mikhail Pozdnyakov

Comment 2 2013-01-24 00:31:52 PST

Created attachment 184424 [details] patch Added some more renaming inside EwkView (m_view -> m_evasObject)

Kenneth Rohde Christiansen

Comment 3 2013-01-24 00:35:38 PST

Comment on attachment 184424 [details] patch LGTM

WebKit Review Bot

Comment 4 2013-01-24 04:46:42 PST

Comment on attachment 184424 [details] patch Rejecting attachment 184424 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 184424, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ate file /tmp/ppp4abyG : No space left on device patch: **** Can't create file /tmp/ppgjwsko : No space left on device fatal: pathspec 'Source/WebKit2/UIProcess/API/efl/EwkView.cpp' did not match any files Failed to git add Source/WebKit2/UIProcess/API/efl/EwkView.cpp. at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 448. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Andreas Kling']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16080641

Kenneth Rohde Christiansen

Comment 5 2013-01-24 07:33:25 PST

Comment on attachment 184424 [details] patch Seems like a cq problem, retry

WebKit Review Bot

Comment 6 2013-01-24 07:45:07 PST

Comment on attachment 184424 [details] patch Rejecting attachment 184424 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 184424, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ate file /tmp/ppQPaFde : No space left on device patch: **** Can't create file /tmp/ppbhK7FJ : No space left on device fatal: pathspec 'Source/WebKit2/UIProcess/API/efl/EwkView.cpp' did not match any files Failed to git add Source/WebKit2/UIProcess/API/efl/EwkView.cpp. at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 448. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Andreas Kling']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16074779

Mikhail Pozdnyakov

Comment 7 2013-01-24 08:22:50 PST

Committed r140686: <http://trac.webkit.org/changeset/140686>

Note You need to log in before you can comment on or make changes to this bug.