Summary: | [Chromium] Fix inclusion of pch .cpp in webcore_platform and webcore_rendering | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Scott Graham <scottmg> | ||||
Component: | New Bugs | Assignee: | Scott Graham <scottmg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dpranke, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Scott Graham
2013-01-23 09:33:36 PST
Created attachment 184258 [details]
Patch
The ['exclude', '.*'], in these targets was excluding the pch cpp file from WinPrecompile.gypi. This works anyway in VS2010 (though is wrong), but VS2012 errors out. Goes with https://codereview.chromium.org/12052029/. Comment on attachment 184258 [details] Patch Clearing flags on attachment: 184258 Committed r140598: <http://trac.webkit.org/changeset/140598> All reviewed patches have been landed. Closing bug. |