Bug 107700

Summary: [Chromium] Fix inclusion of pch .cpp in webcore_platform and webcore_rendering
Product: WebKit Reporter: Scott Graham <scottmg>
Component: New BugsAssignee: Scott Graham <scottmg>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Scott Graham
Reported 2013-01-23 09:33:36 PST
[Chromium] Fix inclusion of pch .cpp in webcore_platform and webcore_rendering
Attachments
Patch (1.76 KB, patch)
2013-01-23 10:25 PST, Scott Graham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Scott Graham
Comment 1 2013-01-23 10:25:38 PST
Created attachment 184258 [details] Patch
Scott Graham
Comment 2 2013-01-23 10:30:31 PST
The ['exclude', '.*'], in these targets was excluding the pch cpp file from WinPrecompile.gypi. This works anyway in VS2010 (though is wrong), but VS2012 errors out. Goes with https://codereview.chromium.org/12052029/.
WebKit Review Bot
Comment 3 2013-01-23 14:51:04 PST
Comment on attachment 184258 [details] Patch Clearing flags on attachment: 184258 Committed r140598: <http://trac.webkit.org/changeset/140598>
WebKit Review Bot
Comment 4 2013-01-23 14:51:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.