Summary: | Web Inspector: expand more chunks in DTE | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Lushnikov <lushnikov> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Lushnikov <lushnikov> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | apavlov, buildbot, dglazkov, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Andrey Lushnikov
2013-01-23 08:49:07 PST
Created attachment 184248 [details]
Patch
Comment on attachment 184248 [details] Patch Attachment 184248 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16078284 New failing tests: inspector/editor/text-editor-selection.html Comment on attachment 184248 [details] Patch Attachment 184248 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16075397 New failing tests: inspector/editor/text-editor-selection.html Comment on attachment 184248 [details] Patch Attachment 184248 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16072459 New failing tests: inspector/editor/text-editor-selection.html Created attachment 184428 [details]
Patch
Comment on attachment 184428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184428&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:936 > + return this.findVisibleChunks(Math.max(visibleFrom - clientHeight, 0), visibleTo + clientHeight); Just patch findVisibleChunks? Created attachment 184474 [details]
Patch
Comment on attachment 184474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184474&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:897 > + var expand = (visibleTo - visibleFrom) * 0.5; var span Comment on attachment 184474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184474&action=review >> Source/WebCore/inspector/front-end/DefaultTextEditor.js:897 >> + var expand = (visibleTo - visibleFrom) * 0.5; > > var span fixed. Created attachment 184488 [details]
Patch
Comment on attachment 184488 [details] Patch Clearing flags on attachment: 184488 Committed r140691: <http://trac.webkit.org/changeset/140691> All reviewed patches have been landed. Closing bug. |