Bug 107698

Summary:

Web Inspector: expand more chunks in DTE

Product:

WebKit

Reporter:

Andrey Lushnikov <lushnikov>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Lushnikov <lushnikov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, buildbot, dglazkov, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Andrey Lushnikov

Reported 2013-01-23 08:49:07 PST

Prior to this moment, only visible chunks get expanded and highlighted, so if user does a scrolling via mouse wheel he might notice highlighter at work. Expanding some more chunks around visible area should improve user experience.

Attachments
Patch (3.28 KB, patch) 2013-01-23 08:53 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Patch (4.55 KB, patch) 2013-01-24 00:51 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Patch (2.99 KB, patch) 2013-01-24 06:05 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Patch (2.98 KB, patch) 2013-01-24 07:22 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andrey Lushnikov

Comment 1 2013-01-23 08:53:56 PST

Created attachment 184248 [details] Patch

WebKit Review Bot

Comment 2 2013-01-23 11:17:24 PST

Comment on attachment 184248 [details] Patch Attachment 184248 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16078284 New failing tests: inspector/editor/text-editor-selection.html

Build Bot

Comment 3 2013-01-23 16:55:15 PST

Comment on attachment 184248 [details] Patch Attachment 184248 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16075397 New failing tests: inspector/editor/text-editor-selection.html

Build Bot

Comment 4 2013-01-23 17:27:23 PST

Comment on attachment 184248 [details] Patch Attachment 184248 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16072459 New failing tests: inspector/editor/text-editor-selection.html

Andrey Lushnikov

Comment 5 2013-01-24 00:51:05 PST

Created attachment 184428 [details] Patch

Pavel Feldman

Comment 6 2013-01-24 05:09:59 PST

Comment on attachment 184428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184428&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:936 > + return this.findVisibleChunks(Math.max(visibleFrom - clientHeight, 0), visibleTo + clientHeight); Just patch findVisibleChunks?

Andrey Lushnikov

Comment 7 2013-01-24 06:05:04 PST

Created attachment 184474 [details] Patch

Pavel Feldman

Comment 8 2013-01-24 06:11:57 PST

Comment on attachment 184474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184474&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:897 > + var expand = (visibleTo - visibleFrom) * 0.5; var span

Andrey Lushnikov

Comment 9 2013-01-24 07:21:57 PST

Comment on attachment 184474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184474&action=review >> Source/WebCore/inspector/front-end/DefaultTextEditor.js:897 >> + var expand = (visibleTo - visibleFrom) * 0.5; > > var span fixed.

Andrey Lushnikov

Comment 10 2013-01-24 07:22:44 PST

Created attachment 184488 [details] Patch

WebKit Review Bot

Comment 11 2013-01-24 09:40:47 PST

Comment on attachment 184488 [details] Patch Clearing flags on attachment: 184488 Committed r140691: <http://trac.webkit.org/changeset/140691>

WebKit Review Bot

Comment 12 2013-01-24 09:40:51 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.