Bug 107695 – [Qt][WebGL] regression(139725) Execution flow never reaches server side part in GraphicsSurface::platformSwapBuffers()

• Component: WebGL
• Status: RESOLVED INVALID

[Viatcheslav Ostapenko]

This change is not right:
-    if (m_private->isReceiver()) {
+    if (m_private->isReceiver() && platformGetTextureID()) {

platformTextureID() creates texture and always returns it, so making server side code unreachable.

[Viatcheslav Ostapenko]

Created attachment 184241 [details]
Patch

[Kalyan]

Comment on attachment 184241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184241&action=review

> Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:558
> +    if (m_private->isReceiver()) {

Shouldn't isReceiver() return false on server side??

[Zeno Albisser]

I am afraid, that this does not fix the issue.
After applying this patch i still do not get any WebGL content.

[Kalyan]

(In reply to comment #3)
> I am afraid, that this does not fix the issue.
> After applying this patch i still do not get any WebGL content.

I don’t understand as to what we are fixing with this patch. On server side isReceiver() should always return false and we dont evaluate the second condition(i.e We use logical And and not or )

[Viatcheslav Ostapenko]

Kalyan is right.

[Viatcheslav Ostapenko]

(In reply to comment #3)
> I am afraid, that this does not fix the issue.
> After applying this patch i still do not get any WebGL content.

I'll try older NVidia cards. I have 9500 GT in one computer.
Don't have problems with GT 550 Ti.