Summary: | [WK2][EFL] Remove unneeded private methods | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||||||
Component: | WebKit2 | Assignee: | Kenneth Rohde Christiansen <kenneth> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, gyuyoung.kim, kalyan.kondapally, laszlo.gombos, mikhail.pozdnyakov, ostap73, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 107657 | ||||||||||
Attachments: |
|
Description
Kenneth Rohde Christiansen
2013-01-23 07:48:05 PST
Created attachment 184234 [details]
Patch
Comment on attachment 184234 [details]
Patch
looks nice.
Comment on attachment 184234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184234&action=review > Source/WebKit2/ChangeLog:3 > + [WK][EFL] Remove unneeded private methods [WK2] ? Comment on attachment 184234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184234&action=review > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:380 > + if (m_pendingSurfaceResize || !m_evasGLSurface) { The way the state is handled before coming here is madness. I am not sure you even need "|| !m_evasGLSurface". I think some clarifying of the state would be beneficial. Created attachment 184452 [details]
Patch
LGTM. Comment on attachment 184452 [details] Patch This needs a rebase after r140686. Created attachment 184957 [details]
Patch
Comment on attachment 184957 [details]
Patch
rs=me
Comment on attachment 184957 [details] Patch Clearing flags on attachment: 184957 Committed r140961: <http://trac.webkit.org/changeset/140961> All reviewed patches have been landed. Closing bug. |