Bug 107688

Summary: Web Inspector: [Canvas] UI: add a selector to capture a single canvas frame vs consecutive frames
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Andrey Adaikin <aandrey>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pfeldman: review+
Screenshot none

Description Andrey Adaikin 2013-01-23 07:24:18 PST 
Allow capturing several canvas frames in a row.

Patch to follow.
Comment 1 Andrey Adaikin 2013-01-23 07:31:33 PST 
Created attachment 184227 [details]
Patch
Comment 2 Andrey Adaikin 2013-01-23 07:33:42 PST 
Created attachment 184228 [details]
Screenshot
Comment 3 Pavel Feldman 2013-01-23 07:36:43 PST 
Comment on attachment 184227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review

> Source/WebCore/inspector/front-end/CanvasProfileView.js:293
> +            setTimeout(this._requestTraceLog.bind(this), 500);

why 500?
Comment 4 Andrey Adaikin 2013-01-23 07:52:21 PST 
Comment on attachment 184227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review

>> Source/WebCore/inspector/front-end/CanvasProfileView.js:293
>> +            setTimeout(this._requestTraceLog.bind(this), 500);
> 
> why 500?

just a number :) any concerns/ideas?
Comment 5 Pavel Feldman 2013-01-23 07:58:14 PST 
Comment on attachment 184227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review

>>> Source/WebCore/inspector/front-end/CanvasProfileView.js:293
>>> +            setTimeout(this._requestTraceLog.bind(this), 500);
>> 
>> why 500?
> 
> just a number :) any concerns/ideas?

Why do you have this delay? Why do you use magic numbers?
Comment 6 Andrey Adaikin 2013-01-23 08:11:11 PST 
(In reply to comment #5)
> (From update of attachment 184227 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review
> 
> >>> Source/WebCore/inspector/front-end/CanvasProfileView.js:293
> >>> +            setTimeout(this._requestTraceLog.bind(this), 500);
> >> 
> >> why 500?
> > 
> > just a number :) any concerns/ideas?
> 
> Why do you have this delay? Why do you use magic numbers?

We have an alive trace log which we must fetch periodically from the backend. To send a new request right away seems too inefficient, thus I timeout a bit.
Comment 7 Andrey Adaikin 2013-01-24 05:44:28 PST 
Committed r140678: <http://trac.webkit.org/changeset/140678>