Bug 107688

Summary: Web Inspector: [Canvas] UI: add a selector to capture a single canvas frame vs consecutive frames
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Andrey Adaikin <aandrey>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pfeldman: review+
Screenshot none

Andrey Adaikin
Reported 2013-01-23 07:24:18 PST
Allow capturing several canvas frames in a row. Patch to follow.
Attachments
Patch (29.00 KB, patch)
2013-01-23 07:31 PST, Andrey Adaikin 		pfeldman: review+
DetailsFormatted DiffDiff
Screenshot (141.38 KB, image/png)
2013-01-23 07:33 PST, Andrey Adaikin 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2013-01-23 07:31:33 PST
Created attachment 184227 [details] Patch
Andrey Adaikin
Comment 2 2013-01-23 07:33:42 PST
Created attachment 184228 [details] Screenshot
Pavel Feldman
Comment 3 2013-01-23 07:36:43 PST
Comment on attachment 184227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review > Source/WebCore/inspector/front-end/CanvasProfileView.js:293 > + setTimeout(this._requestTraceLog.bind(this), 500); why 500?
Andrey Adaikin
Comment 4 2013-01-23 07:52:21 PST
Comment on attachment 184227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review >> Source/WebCore/inspector/front-end/CanvasProfileView.js:293 >> + setTimeout(this._requestTraceLog.bind(this), 500); > > why 500? just a number :) any concerns/ideas?
Pavel Feldman
Comment 5 2013-01-23 07:58:14 PST
Comment on attachment 184227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review >>> Source/WebCore/inspector/front-end/CanvasProfileView.js:293 >>> + setTimeout(this._requestTraceLog.bind(this), 500); >> >> why 500? > > just a number :) any concerns/ideas? Why do you have this delay? Why do you use magic numbers?
Andrey Adaikin
Comment 6 2013-01-23 08:11:11 PST
(In reply to comment #5) > (From update of attachment 184227 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184227&action=review > > >>> Source/WebCore/inspector/front-end/CanvasProfileView.js:293 > >>> + setTimeout(this._requestTraceLog.bind(this), 500); > >> > >> why 500? > > > > just a number :) any concerns/ideas? > > Why do you have this delay? Why do you use magic numbers? We have an alive trace log which we must fetch periodically from the backend. To send a new request right away seems too inefficient, thus I timeout a bit.
Andrey Adaikin
Comment 7 2013-01-24 05:44:28 PST
Committed r140678: <http://trac.webkit.org/changeset/140678>
Note You need to log in before you can comment on or make changes to this bug.