Bug 107648 – Web Inspector: allow user to resize inspector window by dragging the toolbar

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Dmitry Gozman]

When user drags toolbar in docked to bottom mode, we should change the height of the inspector window.

[Dmitry Gozman]

Created attachment 184189 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Pavel Feldman]

Comment on attachment 184189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=184189&action=review

A couple of nits and it is good to land.

> Source/WebCore/inspector/front-end/DockController.js:97
> +    isDockedToBottom: function() {

{ should be on the next line

> Source/WebCore/inspector/front-end/DockController.js:-125
> -            WebInspector.toolbar.setDockedToBottom(this._dockSide === WebInspector.DockController.State.DockedToBottom);

I like reversing this dependency.

> Source/WebCore/inspector/front-end/Toolbar.js:124
> +        this.element.lastHeight = window.innerHeight;

Why storing this property on element? Store it on this with private field.

[Dmitry Gozman]

Created attachment 184202 [details]
Patch

[WebKit Review Bot]

Comment on attachment 184202 [details]
Patch

Clearing flags on attachment: 184202

Committed r140543: <http://trac.webkit.org/changeset/140543>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Andrey Adaikin]

FYI.
plz get used to run JSCompiler WebCore/inspector/compile-front-end.py from time to time:

Source/WebCore/inspector/front-end/Toolbar.js:104: WARNING - inconsistent return type
found   : (boolean|null)
required: boolean
        return WebInspector.dockController && WebInspector.dockController.isDockedToBottom();