Bug 107620

Summary: Make MediaQueryEvaluator(bool) constructor explicit.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: CSSAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, eric.carlson, feature-media-reviews, macpherson, menard, ojan.autocc, shinyak, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Make it explicit
none
Fix a title. none

Description Hayato Ito 2013-01-22 20:39:55 PST 
I had to confess that I've spent a couple of hours on debugging due to this non-explicit constructor.

RuleSet:::addRulesFromSheet is defined:
  RuleSet:addRulesFromSheet(StyleSheetContents*, const MediaQueryEvaluator&, StyleResolver* = 0, const ContainerNode* = 0)

I wrongly called it with 'ruleSet.addRulesFromSheet(sheet, resolver)'. My bad. :(
Comment 1 Hayato Ito 2013-01-22 20:43:12 PST 
Created attachment 184119 [details]
Make it explicit
Comment 2 Hayato Ito 2013-01-22 20:46:41 PST 
Created attachment 184120 [details]
Fix a title.
Comment 3 Shinya Kawanaka 2013-01-22 21:02:36 PST 
Looks ok if all build-bots pass.
Comment 4 WebKit Review Bot 2013-01-22 21:16:10 PST 
Comment on attachment 184120 [details]
Fix a title.

Clearing flags on attachment: 184120

Committed r140503: <http://trac.webkit.org/changeset/140503>
Comment 5 WebKit Review Bot 2013-01-22 21:16:14 PST 
All reviewed patches have been landed.  Closing bug.