| Summary: | [CSS Grid Layout] Add support for max-content | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> | ||||||
| Component: | Layout and Rendering | Assignee: | Julien Chaffraix <jchaffraix> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 103311 | ||||||||
| Attachments: |
|
||||||||
|
Description
Julien Chaffraix
2013-01-22 17:36:51 PST
Created attachment 184095 [details]
Proposed change 1: Merrily add the missing steps from the spec, no code sharing for now.
Comment on attachment 184095 [details] Proposed change 1: Merrily add the missing steps from the spec, no code sharing for now. View in context: https://bugs.webkit.org/attachment.cgi?id=184095&action=review > LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html:10 > + display: -webkit-grid; Can you use grid class in grid.css instead? > LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html:17 > + display: -webkit-grid; Can you use grid class in grid.css instead? > LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html:10 > + display: -webkit-grid; Can you use grid class in grid.css instead? > LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html:17 > + display: -webkit-grid; Can you use grid class in grid.css instead? > LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html:32 > + background-color: blue; > + -webkit-grid-column: 1; > + -webkit-grid-row: 1; This seems redundant with the code in grid.css. Comment on attachment 184095 [details] Proposed change 1: Merrily add the missing steps from the spec, no code sharing for now. View in context: https://bugs.webkit.org/attachment.cgi?id=184095&action=review Thanks Tony! >> LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html:10 >> + display: -webkit-grid; > > Can you use grid class in grid.css instead? Doh! So much for upgrading these tests to grid.css :-/ All those comments will be taking into account and I will double check the file prior to landing. Created attachment 184288 [details]
Patch for landing
Comment on attachment 184288 [details] Patch for landing Clearing flags on attachment: 184288 Committed r140583: <http://trac.webkit.org/changeset/140583> All reviewed patches have been landed. Closing bug. |