| Summary: | [chromium] move most WebViewHost printf calls to WebTestProxy | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dan Carney <dcarney> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, jochen, tkent+wkapi, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 107556 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Dan Carney
2013-01-22 05:59:27 PST
Created attachment 183978 [details]
Patch
Comment on attachment 183978 [details] Patch Looks good. You'll need to rebase this. I verified locally that it works after my fix for bug 107556 landed. Created attachment 184207 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 184207 [details] Patch Attachment 184207 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16063718 New failing tests: plugins/open-and-close-window-with-plugin.html plugins/geturlnotify-during-document-teardown.html Comment on attachment 184207 [details] Patch Attachment 184207 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16075281 New failing tests: plugins/open-and-close-window-with-plugin.html plugins/geturlnotify-during-document-teardown.html Comment on attachment 184207 [details] Patch Rejecting attachment 184207 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 184207, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: nderTree/chromium/TestShell.cpp Hunk #1 succeeded at 221 (offset 2 lines). patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp Hunk #5 succeeded at 1160 (offset 10 lines). Hunk #6 succeeded at 1219 (offset 10 lines). patching file Tools/DumpRenderTree/chromium/WebViewHost.h Hunk #1 succeeded at 86 (offset 1 line). Hunk #2 succeeded at 383 (offset 4 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16078325 Created attachment 184423 [details]
Patch
Comment on attachment 184423 [details]
Patch
rebased
Comment on attachment 184423 [details] Patch Rejecting attachment 184423 [details] from commit-queue. New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Full output: http://queues.webkit.org/results/16097064 Comment on attachment 184423 [details] Patch Clearing flags on attachment: 184423 Committed r140668: <http://trac.webkit.org/changeset/140668> All reviewed patches have been landed. Closing bug. |