Bug 107553

Summary: [chromium] move most WebViewHost printf calls to WebTestProxy
Product: WebKit Reporter: Dan Carney <dcarney>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, jochen, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 107556    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dan Carney
Reported 2013-01-22 05:59:27 PST
[chromium] move most WebViewHost printf calls to WebTestProxy
Attachments
Patch (16.57 KB, patch)
2013-01-22 06:00 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (16.67 KB, patch)
2013-01-23 05:16 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (16.65 KB, patch)
2013-01-24 00:22 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dan Carney
Comment 1 2013-01-22 06:00:30 PST
Created attachment 183978 [details] Patch
jochen
Comment 2 2013-01-23 05:03:15 PST
Comment on attachment 183978 [details] Patch Looks good. You'll need to rebase this. I verified locally that it works after my fix for bug 107556 landed.
Dan Carney
Comment 3 2013-01-23 05:16:23 PST
Created attachment 184207 [details] Patch
WebKit Review Bot
Comment 4 2013-01-23 10:27:54 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 5 2013-01-23 11:25:33 PST
Comment on attachment 184207 [details] Patch Attachment 184207 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16063718 New failing tests: plugins/open-and-close-window-with-plugin.html plugins/geturlnotify-during-document-teardown.html
WebKit Review Bot
Comment 6 2013-01-23 12:00:30 PST
Comment on attachment 184207 [details] Patch Attachment 184207 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16075281 New failing tests: plugins/open-and-close-window-with-plugin.html plugins/geturlnotify-during-document-teardown.html
WebKit Review Bot
Comment 7 2013-01-23 12:26:18 PST
Comment on attachment 184207 [details] Patch Rejecting attachment 184207 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 184207, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: nderTree/chromium/TestShell.cpp Hunk #1 succeeded at 221 (offset 2 lines). patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp Hunk #5 succeeded at 1160 (offset 10 lines). Hunk #6 succeeded at 1219 (offset 10 lines). patching file Tools/DumpRenderTree/chromium/WebViewHost.h Hunk #1 succeeded at 86 (offset 1 line). Hunk #2 succeeded at 383 (offset 4 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16078325
Dan Carney
Comment 8 2013-01-24 00:22:37 PST
Created attachment 184423 [details] Patch
Dan Carney
Comment 9 2013-01-24 00:23:13 PST
Comment on attachment 184423 [details] Patch rebased
WebKit Review Bot
Comment 10 2013-01-24 01:22:18 PST
Comment on attachment 184423 [details] Patch Rejecting attachment 184423 [details] from commit-queue. New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Full output: http://queues.webkit.org/results/16097064
WebKit Review Bot
Comment 11 2013-01-24 02:14:25 PST
Comment on attachment 184423 [details] Patch Clearing flags on attachment: 184423 Committed r140668: <http://trac.webkit.org/changeset/140668>
WebKit Review Bot
Comment 12 2013-01-24 02:14:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.