Bug 107550

Summary: Web Inspector: remove asynchronous behavior from DTE paintLines method
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Andrey Lushnikov
Reported 2013-01-22 05:10:08 PST
Due to the asynchronous nature of paintLines method, it might invalidate DOM couple of times and wait for some period of time before completing its job. During the gap, browser runs a "paint" method to update the image. The "paint" operation is an expensive one - in my experiment, it could last as long as 22ms. That said, remove the asynchronous behavior of paintLines method and estimate how it goes with a synchronous paint. This way we might avoid a lot of unnecessary "repaints".
Attachments
Patch (9.27 KB, patch)
2013-01-22 05:18 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-01-22 05:18:29 PST
Created attachment 183968 [details] Patch
Pavel Feldman
Comment 2 2013-01-22 05:57:15 PST
Comment on attachment 183968 [details] Patch Wouldn't it get stuck on 200 lines 1Mb each?
WebKit Review Bot
Comment 3 2013-01-22 08:20:40 PST
Comment on attachment 183968 [details] Patch Clearing flags on attachment: 183968 Committed r140427: <http://trac.webkit.org/changeset/140427>
WebKit Review Bot
Comment 4 2013-01-22 08:20:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.