Bug 107550 - Web Inspector: remove asynchronous behavior from DTE paintLines method
Summary: Web Inspector: remove asynchronous behavior from DTE paintLines method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 05:10 PST by Andrey Lushnikov
Modified: 2013-01-22 08:20 PST (History)
9 users (show)

See Also:

Attachments
Patch (9.27 KB, patch)
2013-01-22 05:18 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-01-22 05:10:08 PST 
Due to the asynchronous nature of paintLines method, it might invalidate DOM couple of times and wait for some period of time before completing its job. During the gap, browser runs a "paint" method to update the image. The "paint" operation is an expensive one - in my experiment, it could last as long as 22ms. 

That said, remove the asynchronous behavior of paintLines method and estimate how it goes with a synchronous paint. This way we might avoid a lot of unnecessary "repaints".
Comment 1 Andrey Lushnikov 2013-01-22 05:18:29 PST 
Created attachment 183968 [details]
Patch
Comment 2 Pavel Feldman 2013-01-22 05:57:15 PST 
Comment on attachment 183968 [details]
Patch

Wouldn't it get stuck on 200 lines 1Mb each?
Comment 3 WebKit Review Bot 2013-01-22 08:20:40 PST 
Comment on attachment 183968 [details]
Patch

Clearing flags on attachment: 183968

Committed r140427: <http://trac.webkit.org/changeset/140427>
Comment 4 WebKit Review Bot 2013-01-22 08:20:44 PST 
All reviewed patches have been landed.  Closing bug.