Bug 107532

Summary: Avoid unnecessary format conversion for tex{Sub}Image2D() for ImageData of WebGL
Product: WebKit Reporter: Jun Jiang <jun.a.jiang>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, kbr, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Jun Jiang
Reported 2013-01-22 02:26:24 PST
There is mandatory format conversion existed for tex{Sub}Image2D() for ImageData of WebGL, which could be avoided when the destination format is RGBA and the type is UNSIGNED_BYTE and both the preMultiply and flip flags are false.
Attachments
Patch (4.11 KB, patch)
2013-01-22 02:32 PST, Jun Jiang 		no flags
DetailsFormatted DiffDiff
Patch (4.49 KB, patch)
2013-01-22 05:38 PST, Jun Jiang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jun Jiang
Comment 1 2013-01-22 02:32:55 PST
Created attachment 183941 [details] Patch
Jun Jiang
Comment 2 2013-01-22 05:38:59 PST
Created attachment 183971 [details] Patch
Jun Jiang
Comment 3 2013-01-22 05:42:44 PST
Add two comments in the code to make it easy to maintain.
Kenneth Russell
Comment 4 2013-01-23 13:51:20 PST
Comment on attachment 183971 [details] Patch Looks good. r=me
WebKit Review Bot
Comment 5 2013-01-23 14:28:08 PST
Comment on attachment 183971 [details] Patch Clearing flags on attachment: 183971 Committed r140595: <http://trac.webkit.org/changeset/140595>
WebKit Review Bot
Comment 6 2013-01-23 14:28:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.