| Summary: | Avoid unnecessary format conversion for tex{Sub}Image2D() for ImageData of WebGL | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jun Jiang <jun.a.jiang> | ||||||
| Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, kbr, ojan.autocc, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 183941 [details]
Patch
Created attachment 183971 [details]
Patch
Add two comments in the code to make it easy to maintain. Comment on attachment 183971 [details]
Patch
Looks good. r=me
Comment on attachment 183971 [details] Patch Clearing flags on attachment: 183971 Committed r140595: <http://trac.webkit.org/changeset/140595> All reviewed patches have been landed. Closing bug. |
There is mandatory format conversion existed for tex{Sub}Image2D() for ImageData of WebGL, which could be avoided when the destination format is RGBA and the type is UNSIGNED_BYTE and both the preMultiply and flip flags are false.