Bug 107525

Summary: sheriff-bot should have a suggest-reviewers command
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: abarth, alancutter, dpranke, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 107528    
Bug Blocks:    

Description Eric Seidel (no email) 2013-01-22 01:54:20 PST
sheriff-bot should have a suggest-reviewers command

Just like webkit-patch suggest reviewers, but public in the channel.

It makes it trivial when someone shows up asking for a review to teach them how to get one.

<eseidel> sheriff-bot: suggest-reviewers 12345
<sheriff-bot> eseidel: Analyzing patch 23243 on bug 12353 for the best possible reviewrs
<sheriff-bot> eseidel: Added 5 reviewers to bug 12345: abarth, dpranke, ojan, othermaciej and darin.
Comment 1 Zan Dobersek 2013-01-23 03:38:03 PST
AFAIU, this should apply any attachment up for review in the specified bug, run webkit-patch suggest-reviewers, and then CC the suggestions to the bug?
Comment 2 Eric Seidel (no email) 2013-01-23 03:41:33 PST
Correct.  As I note in the dependent bug, suggest-reviewers may need a bit of clean-up before it can be made prime-time.  Currently it can be a bit over-zealous with its ccing.
Comment 3 Zan Dobersek 2013-01-23 05:23:47 PST
I find suggest-reviewers command to be terribly slow. Is it just my system or is this a common problem? If this is widespread, does it make sense to hog the sheriffbot with executing this command?
Comment 4 Zan Dobersek 2013-01-23 06:13:33 PST
(In reply to comment #3)
> I find suggest-reviewers command to be terribly slow. Is it just my system or is this a common problem? If this is widespread, does it make sense to hog the sheriffbot with executing this command?

This actually works pretty fast when using a git-svn checkout, so I'm removing this complaint.