Summary: | [v8] Convert string conversion calls to one byte versions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dan Carney <dcarney> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, haraken, japhet, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dan Carney
2013-01-22 01:52:23 PST
Created attachment 183932 [details]
Patch
Comment on attachment 183932 [details]
Patch
Looks OK
Comment on attachment 183932 [details] Patch Clearing flags on attachment: 183932 Committed r140409: <http://trac.webkit.org/changeset/140409> All reviewed patches have been landed. Closing bug. Comment on attachment 183932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183932&action=review > Source/WebCore/bindings/v8/SerializedScriptValue.cpp:325 > - string->WriteAscii(buffer, 0, length, v8StringWriteOptions()); > + string->WriteOneByte(byteAt(m_position), 0, length, v8StringWriteOptions()); What'st he difference between these two calls? (Just curious.) Comment on attachment 183932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183932&action=review >> Source/WebCore/bindings/v8/SerializedScriptValue.cpp:325 >> + string->WriteOneByte(byteAt(m_position), 0, length, v8StringWriteOptions()); > > What'st he difference between these two calls? (Just curious.) WriteAscii is being removed from the v8 api after WebKit and chrome have removed it. WriteOneByte takes a uint8_t* as the first argument to indicate that it writes Latin-1. Makes sense. Thanks! |