Bug 107520

Summary: [V8] Make an Isolate parameter mandatory in toV8()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, eric.carlson, feature-media-reviews, japhet, macpherson, menard, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2013-01-22 01:26:51 PST
Now it's safe to remove an optional Isolate parameter.
Attachments
Patch (28.81 KB, patch)
2013-01-22 01:28 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-01-22 01:28:05 PST
Created attachment 183923 [details] Patch
Adam Barth
Comment 2 2013-01-22 01:29:30 PST
Comment on attachment 183923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183923&action=review > Source/WebKit/chromium/src/WebBlob.cpp:66 > - return toV8(m_private.get(), v8::Handle<v8::Object>()); > + return toV8(m_private.get(), v8::Handle<v8::Object>(), v8::Isolate::GetCurrent()); So sad. We shouldn't have added this API.
WebKit Review Bot
Comment 3 2013-01-22 01:49:51 PST
Comment on attachment 183923 [details] Patch Clearing flags on attachment: 183923 Committed r140401: <http://trac.webkit.org/changeset/140401>
WebKit Review Bot
Comment 4 2013-01-22 01:49:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.